Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve README: Fairplay getCertificacte #103

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ash-r1
Copy link

@ash-r1 ash-r1 commented May 1, 2020

I met an error that #80 mentions. It caused by wrongly passing an arraybuffer rather than a unit8array for getCertificate callback.

I think it would be nice to mention a datatype of this callback.

Also, it's easier to use if README mentions videojs.xhr func, so I added an example code in this PR.

@ash-r1 ash-r1 force-pushed the improve-readme-about-datatype branch from 7f08b50 to 6b150d6 Compare May 1, 2020 03:42
@misteroneill misteroneill changed the base branch from master to main August 24, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant