fix: remove counterproductive assert() (fix #115)

vikejs · May 28, 2024 · 2cc16cf · 2cc16cf
1 parent 0f83834
commit 2cc16cf
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 12 deletions.
diff --git a/packages/vike-react/src/hooks/usePageContext.tsx b/packages/vike-react/src/hooks/usePageContext.tsx
@@ -4,14 +4,12 @@ export { PageContextProvider }
 import React, { useContext } from 'react'
 import { getGlobalObject } from '../utils/getGlobalObject.js'
 import type { PageContext } from 'vike/types'
-import { assert } from '../utils/assert.js'
 
 const globalObject = getGlobalObject('PageContextProvider.ts', {
   reactContext: React.createContext<PageContext>(undefined as never)
 })
 
 function PageContextProvider({ pageContext, children }: { pageContext: PageContext; children: React.ReactNode }) {
-  assert(pageContext)
   const { reactContext } = globalObject
   return <reactContext.Provider value={pageContext}>{children}</reactContext.Provider>
 }
@@ -24,9 +22,5 @@ function PageContextProvider({ pageContext, children }: { pageContext: PageConte
 function usePageContext(): PageContext {
   const { reactContext } = globalObject
   const pageContext = useContext(reactContext)
-  /* React throws an error upon wrong hook usage, so I guess a nice error message isn't needed? And I guess we can therefore assume and assert pageContext to have been provided? Let's see if users report back an assert() failure.
-  if (!pageContext) throw new Error('<PageContextProvider> is needed for being able to use usePageContext()')
-  */
-  assert(pageContext)
   return pageContext
 }
diff --git a/packages/vike-react/src/utils/assert.ts b/packages/vike-react/src/utils/assert.ts