Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add useNavigate - single file version #124

Closed
wants to merge 9 commits into from
Closed

add useNavigate - single file version #124

wants to merge 9 commits into from

Conversation

nitedani
Copy link
Member

@nitedani nitedani commented Jun 28, 2024 •
edited by brillout
Loading

Second version of useNavigate PR, single file, but imports vike/abort and vike/client/router both on the client and server

Alternative implemenation: #123.

@brillout
Copy link
Member

but imports vike/abort and vike/client/router both on the client and server

That isn't an issue: navigate() can be imported on the server-side (it throws an error if called on the server-side).

@brillout brillout force-pushed the main branch 6 times, most recently from 31e3224 to b4f4841 Compare July 8, 2024 08:17
@brillout brillout mentioned this pull request Aug 19, 2024
Closed
@brillout
Copy link
Member

Let's re-open once we work on this again.

@brillout brillout closed this Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nitedani @brillout