Decrease opcache.jit_buffer_size to 128M #11168
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of PHP 8.4, this is the maximum value available for AArch64. Without
this change, running Psalm with PHP 8.4 on that architecture results in
a warning:
```
Warning: JIT on AArch64 doesn't support opcache.jit_buffer_size above 128M.
```
It's still possible to configure up to 2G for x86_64, so we could keep the
512M value on that architecture at the cost of a bit more complexity to
detect the PHP version and current CPU architecture. (Looks like `php_uname('m')`
would be the way to check CPU arch.)
|
Based on the CI failures, maybe we need 512M in the Windows configuration? I'm not sure what to make of the failure. I'll await general feedback before I change anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of PHP 8.4, this is the maximum value available for AArch64. Without this change, running Psalm with PHP 8.4 on that architecture results in a warning:
It's still possible to configure up to 2G for x86_64, so we could keep the 512M value on that architecture at the cost of a bit more complexity to detect the PHP version and current CPU architecture. (Looks like
php_uname('m')would be the way to check CPU arch.)