Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(log): Add MemoryLog class #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(log): Add MemoryLog class #11

wants to merge 1 commit into from

Conversation

ibgreen
Copy link
Contributor

@ibgreen ibgreen commented Oct 17, 2024

  • Enables apps to log against an abstract Logger interface
  • Can be a traditional Log (ConsoleLog) instance
  • or a MemoryLog instance that log into a message array that can be presented in a UI.

This way e.g. loaders.gl loaders can log issues during parsing into an application provided log object.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11377118321

Details

  • 37 of 99 (37.37%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.9%) to 64.351%

Changes Missing Coverage Covered Lines Changed/Added Lines %
modules/react-bench/src/components/bench-results.tsx 0 1 0.0%
modules/log/src/loggers/logger.ts 0 29 0.0%
modules/log/src/loggers/memory-log.ts 13 45 28.89%
Totals Coverage Status
Change from base Build 10627072284: -0.9%
Covered Lines: 2162
Relevant Lines: 3421

💛 - Coveralls

@ibgreen ibgreen requested a review from Pessimistress October 17, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants