Merge pull request #1915 from visualize-admin/feat/confidence-interva…

…ls-formatting feat: Improve confidence intervals formatting
visualize-admin · Nov 26, 2024 · 3d066ba · 3d066ba
2 parents e5ebe61 + e8c18e6
commit 3d066ba
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 39 deletions.
diff --git a/app/charts/shared/chart-state.ts b/app/charts/shared/chart-state.ts
@@ -433,7 +433,7 @@ export const useNumericalYErrorVariables = (
         const cil = getYConfidenceIntervalLower(d);
         const ciu = getYConfidenceIntervalUpper(d);
         const unit = yConfidenceIntervalUpperMeasure?.unit ?? "";
-        return ` -${cil}${unit}, +${ciu}${unit}`;
+        return `, [-${cil}${unit}, +${ciu}${unit}]`;
       }
     },
     [

diff --git a/app/rdf/light-cube.ts b/app/rdf/light-cube.ts
@@ -7,10 +7,7 @@ import {
 } from "@/domain/data";
 import { getCubeMetadata } from "@/rdf/query-cube-metadata";
 import { getCubePreview } from "@/rdf/query-cube-preview";
-import {
-  getCubeComponentTermsets,
-  getCubeTermsets,
-} from "@/rdf/query-termsets";
+import { getCubeComponentTermsets } from "@/rdf/query-termsets";
 
 type LightCubeOptions = {
   iri: string;
@@ -48,13 +45,6 @@ export class LightCube {
     return this.metadata;
   }
 
-  public async fetchTermsets() {
-    return await getCubeTermsets(this.iri, {
-      locale: this.locale,
-      sparqlClient: this.sparqlClient,
-    });
-  }
-
   public async fetchComponentTermsets() {
     return await getCubeComponentTermsets(this.iri, {
       locale: this.locale,

diff --git a/app/rdf/query-termsets.ts b/app/rdf/query-termsets.ts
@@ -1,37 +1,11 @@
 import groupBy from "lodash/groupBy";
 import ParsingClient from "sparql-http-client/ParsingClient";
 
-import { ComponentTermsets, Termset } from "@/domain/data";
+import { ComponentTermsets } from "@/domain/data";
 import { stringifyComponentId } from "@/graphql/make-component-id";
 import { queryCubeUnversionedIri } from "@/rdf/query-cube-unversioned-iri";
 import { buildLocalizedSubQuery } from "@/rdf/query-utils";
 
-export const getCubeTermsets = async (
-  iri: string,
-  options: {
-    locale: string;
-    sparqlClient: ParsingClient;
-  }
-): Promise<Termset[]> => {
-  const { sparqlClient, locale } = options;
-  const qs = await sparqlClient.query.select(
-    `PREFIX meta: <https://cube.link/meta/>
-PREFIX schema: <http://schema.org/>
-
-SELECT DISTINCT ?termsetIri ?termsetLabel WHERE {
-  ?termsetIri meta:isUsedIn <${iri}> .
-  ${buildLocalizedSubQuery("termsetIri", "schema:name", "termsetLabel", { locale })}
-}`,
-    { operation: "postUrlencoded" }
-  );
-
-  return qs.map((result) => ({
-    iri: result.termsetIri.value,
-    label: result.termsetLabel.value,
-    __typename: "Termset",
-  }));
-};
-
 export const getCubeComponentTermsets = async (
   iri: string,
   options: {