fix: Correctly handle cube metadata #1143
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1138.
Closes #1131.
This PR:
shacl:nodeKind
=shacl:Literal
. This results in smaller queries when fetching observations and should thus improve overall performance of the application a bit,rdf-to-visualize
part of the documentation to be up-to-date when it comes to definingisLiteral
andisNumerical
dimension properties.@Rdataflow I hope this should align the way we handle cubes with the cube spec – let me know if there is anything else you've identified (looks like the
Data types
section of the spec is not very extensive).I didn't introduce any changes to the way we detect
isNumerical
property, as I believe it's done correctly (theEnergy
dimension mentioned in #1131 lacks thedataType
property altogether, that's why it's marked as not numerical). I believe this should be fixed in the data.How to test
Literal
dimension type detection).