This repository has been archived by the owner on Sep 29, 2023. It is now read-only.
Proposal for an implementation of a recordBone #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
recordBone can be used to store a data structure defined via a RelSkel within a skeleton. This enables to build more complex building blocks within a skeleton without adding a new module for that.
|
I would like to defer this one to 2.5 or 3.0, just from looking at the code there are too many open questions regarding this one (Representation for searching/ordering/filtering in the datastore? What's the point of having this bone with multiple=False? How to integrate #71? What about inter-bone dependencies / Skeleton validation) |
sveneberth
previously requested changes
Mar 26, 2019
…ormatString); removed Code that handled cases that are now excluded
|
@phorward Can you run an extensive test on this? I've added the necessary constraints and removed code that handled the now forbidden corner-cases. Also i improved handling of non-required bones. |
akelch
approved these changes
Jun 7, 2019
tsteinruecken
approved these changes
Jun 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recordBone can be used to store a data structure defined via a RelSkel within a skeleton. This enables to build more complex building blocks within a skeleton without adding a new module for that.