Replace old audio visualizer #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivrekar
approved these changes
Nov 26, 2018
| initVisualizer(); | ||
| } | ||
|
|
||
| private void initVisualizer() { |
There was a problem hiding this comment.
Nice! I like how this is much cleaner than before. good call!
|
|
||
| private void initVisualizer() { | ||
| barVisualizer = findViewById(R.id.visualizer); | ||
| //barVisualizer.setColor(Color.argb(1, Color.red(206), Color.green(66), Color.blue(244))); |
There was a problem hiding this comment.
Let's go with rgb(219,24,103) for now! This is the theme pink (Dogwood Rose). Also, once we have some of the more structural things in place, it would be cool to address #4 by implementing some sort of gradient/color changing for this bar visualizer if all goes well!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use: https://github.com/GautamChibde/android-audio-visualizer/blob/master/audiovisualizer/src/main/java/com/chibde/BaseVisualizer.java
instead of previous visualizer.
TODO: Needs RGB values of the color that we want!