Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable weather/wordnik by default if no API keys provided #31

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

vortigont
Copy link
Contributor

@vortigont vortigont commented Dec 18, 2024

if no API keys were provided on-build then disable updates on boot and do not hammer API servers with malformed requests

Copy link
Owner

@vladkorotnev vladkorotnev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the two log things, otherwise LGTM

src/service/owm/weather.cpp Outdated Show resolved Hide resolved
src/service/wordnik.cpp Outdated Show resolved Hide resolved
src/service/owm/weather.cpp Show resolved Hide resolved
@vladkorotnev vladkorotnev changed the base branch from main to develop December 18, 2024 14:46
if no API keys were provided on build then disable updates on boot
and do not hummer API servers with malformed requests
@vladkorotnev vladkorotnev merged commit 453d689 into vladkorotnev:develop Dec 19, 2024
@vortigont vortigont deleted the noapikey branch December 19, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants