Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add rhsm_enabled for Red Hat Enterprise Linux #980

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

feat: add rhsm_enabled for Red Hat Enterprise Linux #980

wants to merge 1 commit into from

Conversation

nesies
Copy link

@nesies nesies commented Nov 6, 2024 •
edited by tenthirtyam
Loading

Summary of Pull Request

Add a new bool variable rhsm_enabled, to enable or not Red Hat Subscription Manager

Default: true to maintain backward compatibility.

Type of Pull Request

  • This is a bugfix. type/bug
  • This is an enhancement or feature. type/feature or type/enhancement
  • This is a documentation update. type/docs
  • This is a refactoring update. type/refactor
  • This is a chore. type/chore
  • This is something else.
    Please describe:

Related to Existing Issues

Closes #977

Test and Documentation Coverage

  • Tests have been completed.
  • Documentation has been added or updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@nesies nesies requested a review from a team as a code owner November 6, 2024 16:11
@nesies nesies requested a review from burnsjared0415 November 6, 2024 16:11
@nesies nesies force-pushed the feat_add-rhsm_enabled branch 2 times, most recently from 1557191 to 8d7633d Compare November 6, 2024 16:13
tenthirtyam
tenthirtyam requested changes Nov 6, 2024
View reviewed changes
builds/linux/rhel/8/linux-rhel.pkr.hcl Show resolved Hide resolved
builds/linux/rhel/8/variables.pkr.hcl Outdated Show resolved Hide resolved
builds/linux/rhel/9/variables.pkr.hcl Outdated Show resolved Hide resolved
builds/linux/rhel/9/variables.pkr.hcl Outdated Show resolved Hide resolved
builds/rhsm.pkrvars.hcl.example Show resolved Hide resolved
builds/linux/rhel/9/variables.pkr.hcl Outdated Show resolved Hide resolved
builds/linux/rhel/9/variables.pkr.hcl Outdated Show resolved Hide resolved
builds/linux/rhel/9/variables.pkr.hcl Outdated Show resolved Hide resolved
@tenthirtyam tenthirtyam changed the title feat: add rhsm_enabled to enable or disable Red Hat subscription manager feat: add rhsm_enabled for Red Hat subscription manager Nov 6, 2024
@tenthirtyam tenthirtyam changed the title feat: add rhsm_enabled for Red Hat subscription manager feat: add rhsm_enabled for Red Hat subscription manager Nov 6, 2024
@tenthirtyam tenthirtyam removed the request for review from burnsjared0415 November 6, 2024 19:43
@tenthirtyam tenthirtyam added the type/enhancement Enhancement label Nov 6, 2024
@tenthirtyam tenthirtyam added this to the v0.22.0 milestone Nov 6, 2024
@tenthirtyam tenthirtyam changed the title feat: add rhsm_enabled for Red Hat subscription manager feat: add rhsm_enabled for Red Hat Enterprise Linux Nov 6, 2024
@tenthirtyam
Copy link
Collaborator

Hi @nesies - please amend your commit with the required sign-off. Once updated, we'll be able to review and proceed.

Thanks!

Ryan Johnson
Distinguished Engineer, VMware by Broadcom

@tenthirtyam tenthirtyam added the status/awaitng-response Awaiting Response label Nov 21, 2024
@nesies nesies force-pushed the feat_add-rhsm_enabled branch 4 times, most recently from 1fc6971 to 8189ef3 Compare November 21, 2024 14:56
tenthirtyam
tenthirtyam previously approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - added two commits to include in the v0.22.0 release.

tenthirtyam
tenthirtyam reviewed Nov 21, 2024
View reviewed changes
builds/linux/rhel/9/linux-rhel.pkrvars.hcl.example Outdated
@@ -21,3 +21,20 @@ vm_firmware = "efi-secure"
iso_datastore_path = "iso/linux/rhel"
iso_content_library_item = "rhel-9.4-x86_64-dvd"
iso_file = "rhel-9.4-x86_64-dvd.iso"

rpm_gpg_keys = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this only be used if you want to use specific GPG keys or does this need to be new requirement?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by default, it seems there is no gpg key in RedHat

tenthirtyam
tenthirtyam reviewed Nov 21, 2024
View reviewed changes
builds/linux/rhel/9/linux-rhel.pkr.hcl
Comment on lines +78 to +80
rpm_gpg_keys = var.rpm_gpg_keys
yum_repositories = var.yum_repositories
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be only for RHEL or expanded to the other RHEL-based distributions?

Copy link
Author

@nesies nesies Nov 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even if not using RHSM, it can be usefull

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this should ideally be added to support the other RHEL-based distributions in the project.

@nesies nesies force-pushed the feat_add-rhsm_enabled branch from 504ca04 to c7b39bb Compare November 26, 2024 14:27
@tenthirtyam tenthirtyam force-pushed the feat_add-rhsm_enabled branch 2 times, most recently from bd642bc to 7c00e18 Compare December 2, 2024 19:31
@tenthirtyam tenthirtyam marked this pull request as draft December 2, 2024 19:32
@tenthirtyam
Copy link
Collaborator

Marked as draft until changes are addressed.

@tenthirtyam tenthirtyam force-pushed the develop branch 3 times, most recently from d75e82e to d3c64d1 Compare December 5, 2024 19:51
@nesies @tenthirtyam
feat: add rhsm_enabled to enable or disable Red Hat
4c12186 
Add a new bool variable `rhsm_enabled`, to enable or not Red Hat Subscription Manager

Default: `true` to maintain backward compatibility.

Closes vmware-samples#977

Signed-off-by: Fabien SEISEN <seisen@gmail.com>
@tenthirtyam tenthirtyam force-pushed the feat_add-rhsm_enabled branch from 7c00e18 to 4c12186 Compare December 11, 2024 15:10
@tenthirtyam
Copy link
Collaborator

@nesies this pull request will need some updates for full coverage in other rhel-based machines if including rpm_gpg_keys and yum_repositories.

@nesies
Copy link
Author

nesies commented Dec 11, 2024

i need some time to see and implement that for other RedHat bases distros, thx

@tenthirtyam tenthirtyam modified the milestones: v0.22.0, Backlog Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenthirtyam tenthirtyam tenthirtyam left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@nesies nesies

Labels
status/awaitng-response Awaiting Response type/enhancement Enhancement
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

Add support for enablement of Red Hat Subscription Manager
2 participants
@nesies @tenthirtyam