Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expanding altreps with attributes #46

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

trossi
Copy link
Contributor

@trossi trossi commented Oct 2, 2024

References to issues or other PRs

See discussion in #45 (comment).

Describe the proposed changes

This PR will fix setting altrep attributes when expand_altrep=True (default). If altrep's attributes are NILVALUE, then attributes are not set in the expanded object.

Additional information

The test files are generated by using the example here.

Checklist before requesting a review

  • I have performed a self-review of my code
  • The code conforms to the style used in this package (checked with Ruff)
  • The code is fully documented and typed (type-checked with Mypy)
  • I have added thorough tests for the new/changed functionality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant