feat: add validation for empty options while setting two factor auth

vormkracht10 · Oct 12, 2024 · e83e413 · e83e413
1 parent 817026c
commit e83e413
Showing 1 changed file with 12 additions and 4 deletions.
diff --git a/src/Pages/TwoFactor.php b/src/Pages/TwoFactor.php
@@ -193,11 +193,19 @@ public function enableAction(): Action
                 $formData['email'] = $data['email'];
             }
 
-            if ($this->twoFactorData['option']) {
-                $formData['two_factor_type'] = TwoFactorType::tryFrom($this->twoFactorData['option']);
-            }
+            try {
+                if ($this->twoFactorData['option']) {
+                    $formData['two_factor_type'] = TwoFactorType::tryFrom($this->twoFactorData['option']);
+                }
+            } catch (\Exception $e) {
+                Notification::make()
+                        ->title('Error!')
+                        ->body(__('Please select a method of authentication.'))
+                        ->danger()
+                        ->send();
+                return;
+            }            /** @var array{two_factor_type: TwoFactorType|null, email?: mixed} $formData */
 
-            /** @var array{two_factor_type: TwoFactorType|null, email?: mixed} $formData */
             if (
                 isset($formData['two_factor_type']) &&
                 ($formData['two_factor_type'] === TwoFactorType::email || $formData['two_factor_type'] === TwoFactorType::phone)