-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add validation for empty options while setting two factor auth #52
feat: add validation for empty options while setting two factor auth #52
Conversation
What do you think of this approach? Defining a default value from the beginning avoiding the null value error? |
Excuse me for the late response, I was on a holiday. I will check it asap. |
Is it possible for you to fix the PHPStan errors? The solutions seems good to me @lucascnunes |
Working on it |
Seems like these errors are still happening @lucascnunes:
|
Seems like you didn't commit changes, I don't see any changes in your last commit @lucascnunes |
b73de07
to
750f3c4
Compare
Finally! 😅 I've never used PHPStan, have no idea what type of error was that. If it's all correct, I'm glad I could help a little bit, thanks for the opportunity. |
Thanks! I will merge the PR |
Adding validation to the form while setting up the Two Factor Authentication, if the user doesn't select any option, was returning an error.