Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add package manage #336

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add package manage #336

wants to merge 1 commit into from

Conversation

jsfrerot
Copy link

@jsfrerot jsfrerot commented Mar 9, 2023

Add the option to manage or not the package. Don't change default behaviour.

@jsfrerot
add package manage
590f98f 
Add the option to manage or not the package. Don't change default behaviour.
kenyon
kenyon reviewed Mar 9, 2023
View reviewed changes
Copy link
Member

@kenyon kenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to add tests for this, where it makes sure the package resource is in the catalog by default, and that it's not in the catalog when $manage_package = false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenyon kenyon kenyon left review comments

Assignees
No one assigned
Labels
needs-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsfrerot @kenyon