Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix acks not on ActiveMQ Artemis: use ack MESSAGE frame header, not message-id #92

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Fix acks not on ActiveMQ Artemis: use ack MESSAGE frame header, not message-id #92

merged 3 commits into from
Nov 5, 2024

Conversation

vrslev
Copy link
Owner

@vrslev vrslev commented Nov 5, 2024 •
edited
Loading

From spec:

If the message is received from a subscription that requires explicit acknowledgment (either client or client-individual mode) then the MESSAGE frame MUST also contain an ack header with an arbitrary value. This header will be used to relate the message to a subsequent ACK or NACK frame.

Previously we've used message-id header, not we use ack.

@vrslev vrslev changed the title Fix acks on ActiveMQ Classic: use ack MESSAGE frame header, not message-id Fix acks not on ActiveMQ Artemis: use ack MESSAGE frame header, not message-id Nov 5, 2024
@vrslev
Copy link
Owner Author

vrslev commented Nov 5, 2024

Closes #89

@vrslev vrslev linked an issue Nov 5, 2024 that may be closed by this pull request
Unexpected ACK received for message-id [null] #89
Closed
@vrslev vrslev merged commit 6014b67 into main Nov 5, 2024
8 checks passed
@vrslev vrslev deleted the fix-acks-on-activemq-classic branch November 5, 2024 07:23
@vrslev vrslev mentioned this pull request Nov 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected ACK received for message-id [null]
1 participant
@vrslev