Skip to content

Commit

Permalink
Merge pull request #100 from vsoch/update-container-base
Browse files Browse the repository at this point in the history 
fix bug with docker build
  • Loading branch information
@vsoch
vsoch authored Dec 8, 2023
2 parents 81b48d9 + d2ea9c2 commit 0969c26
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 11 deletions.
17 changes: 9 additions & 8 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,12 @@ represented by the pull requests that fixed them. Critical items to know are:
Versions correspond with GitHub releases that can be referenced with @ using actions.

## [master](https://github.com/vsoch/pull-request-action/tree/master) (master)
- bugfix of missing output values (1.0.23)
- bugfix of token handling if 401 error received (missing 401 case) (1.0.21)
- bugfix of writing to environment file (missing newline) (1.0.19)
- bugfix of missing from branch with scheduled run (1.0.16)
- forgot to add assignees (1.0.15)
- output and environment variables for PR number and return codes (1.0.5)
- added support for reviewer (individual and team) assignments (1.0.4)
- added support for maintainer can modify and assignees (1.0.3)
- alpine cannot install to system python anymore (1.1.0)
- bugfix of missing output values (1.0.23)
- bugfix of token handling if 401 error received (missing 401 case) (1.0.21)
- bugfix of writing to environment file (missing newline) (1.0.19)
- bugfix of missing from branch with scheduled run (1.0.16)
- forgot to add assignees (1.0.15)
- output and environment variables for PR number and return codes (1.0.5)
- added support for reviewer (individual and team) assignments (1.0.4)
- added support for maintainer can modify and assignees (1.0.3)
8 changes: 5 additions & 3 deletions Dockerfile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,11 @@ LABEL "com.github.actions.description"="Create a pull request when a branch is c
LABEL "com.github.actions.icon"="activity"
LABEL "com.github.actions.color"="yellow"

RUN apk --no-cache add python3 py3-pip git bash && \
pip3 install requests
# Newer alpine we are not allowed to install to system python
RUN apk --no-cache add python3 py3-pip py3-virtualenv git bash && \
python3 -m venv /opt/env && \
/opt/env/bin/pip3 install requests
COPY pull-request.py /pull-request.py

RUN chmod u+x /pull-request.py
ENTRYPOINT ["python3", "/pull-request.py"]
ENTRYPOINT ["/opt/env/bin/python3", "/pull-request.py"]

2 comments on commit 0969c26

@mikeknack86
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -14,11 +14,12 @@ represented by the pull requests that fixed them. Critical items to know are:
Versions correspond with GitHub releases that can be referenced with @ using actions. Versions correspond with GitHub releases that can be referenced with @ using actions.

master (master) ## master (master)

  • bugfix of missing output values (1.0.23) - alpine cannot install to system python anymore (1.1.0)
  • bugfix of token handling if 401 error received (missing 401 case) (1.0.21) - bugfix of missing output values (1.0.23)
  • bugfix of writing to environment file (missing newline) (1.0.19) - bugfix of token handling if 401 error received (missing 401 case) (1.0.21)
  • bugfix of missing from branch with scheduled run (1.0.16) - bugfix of writing to environment file (missing newline) (1.0.19)
  • forgot to add assignees (1.0.15) - bugfix of missing from branch with scheduled run (1.0.16)
  • output and environment variables for PR number and return codes (1.0.5) - forgot to add assignees (1.0.15)
  • added support for reviewer (individual and team) assignments (1.0.4) - output and environment variables for PR number and return codes (1.0.5)
  • added support for maintainer can modify and assignees (1.0.3) - added support for reviewer (individual and team) assignments (1.0.4)
  • added support for maintainer can modify and assignees (1.0.3)
    8 changes: 5 additions & 3 deletions8
    Dockerfile
    Original file line number Original file line Diff line number Diff line change
    @@ -7,9 +7,11 @@ LABEL "com.github.actions.description"="Create a pull request when a branch is c
    LABEL "com.github.actions.icon"="activity" LABEL "com.github.actions.icon"="activity"
    LABEL "com.github.actions.color"="yellow" LABEL "com.github.actions.color"="yellow"

RUN apk --no-cache add python3 py3-pip git bash && \ # Newer alpine we are not allowed to install to system python
pip3 install requests RUN apk --no-cache add python3 py3-pip py3-virtualenv git bash &&
python3 -m venv /opt/env &&
/opt/env/bin/pip3 install requests
COPY pull-request.py /pull-request.py COPY pull-request.py /pull-request.py

RUN chmod u+x /pull-request.py RUN chmod u+x /pull-request.py
ENTRYPOINT ["python3", "/pull-request.py"] ENTRYPOINT ["/opt/env/bin/python3", "/pull-request.py"]
0 comments on commit 0969c26

@mikeknack86
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -14,11 +14,12 @@ represented by the pull requests that fixed them. Critical items to know are:
Versions correspond with GitHub releases that can be referenced with @ using actions. Versions correspond with GitHub releases that can be referenced with @ using actions.

master (master) ## master (master)

  • bugfix of missing output values (1.0.23) - alpine cannot install to system python anymore (1.1.0)
  • bugfix of token handling if 401 error received (missing 401 case) (1.0.21) - bugfix of missing output values (1.0.23)
  • bugfix of writing to environment file (missing newline) (1.0.19) - bugfix of token handling if 401 error received (missing 401 case) (1.0.21)
  • bugfix of missing from branch with scheduled run (1.0.16) - bugfix of writing to environment file (missing newline) (1.0.19)
  • forgot to add assignees (1.0.15) - bugfix of missing from branch with scheduled run (1.0.16)
  • output and environment variables for PR number and return codes (1.0.5) - forgot to add assignees (1.0.15)
  • added support for reviewer (individual and team) assignments (1.0.4) - output and environment variables for PR number and return codes (1.0.5)
  • added support for maintainer can modify and assignees (1.0.3) - added support for reviewer (individual and team) assignments (1.0.4)
  • added support for maintainer can modify and assignees (1.0.3)
    8 changes: 5 additions & 3 deletions8
    Dockerfile
    Original file line number Original file line Diff line number Diff line change
    @@ -7,9 +7,11 @@ LABEL "com.github.actions.description"="Create a pull request when a branch is c
    LABEL "com.github.actions.icon"="activity" LABEL "com.github.actions.icon"="activity"
    LABEL "com.github.actions.color"="yellow" LABEL "com.github.actions.color"="yellow"

RUN apk --no-cache add python3 py3-pip git bash && \ # Newer alpine we are not allowed to install to system python
pip3 install requests RUN apk --no-cache add python3 py3-pip py3-virtualenv git bash &&
python3 -m venv /opt/env &&
/opt/env/bin/pip3 install requests
COPY pull-request.py /pull-request.py COPY pull-request.py /pull-request.py

RUN chmod u+x /pull-request.py RUN chmod u+x /pull-request.py
ENTRYPOINT ["python3", "/pull-request.py"] ENTRYPOINT ["/opt/env/bin/python3", "/pull-request.py"]
0 comments on commit 0969c26

Please sign in to comment.