Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile: remove CMD line and docker-compose file is added #128

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Dockerfile: remove CMD line and docker-compose file is added #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,5 +134,4 @@ COPY --chown=monero-lws:monero-lws --from=build /monero-lws/build/src/* /usr/loc
# Expose REST server port
EXPOSE 8443

ENTRYPOINT ["monero-lws-daemon", "--db-path=/home/monero-lws/.bitmonero/light_wallet_server"]
CMD ["--daemon=tcp://monerod:18082", "--sub=tcp://monerod:18083", "--log-level=4"]
ENTRYPOINT ["monero-lws-daemon"]
33 changes: 33 additions & 0 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
services:
monero-lws:
# depends_on:
# - monero
container_name: monero-lws
build:
context: .
restart: always
ports:
- 8443:8443
command:
- --db-path=/home/monero-lws/.bitmonero/light_wallet_server
- --daemon=tcp://monero:1882
- --sub=tcp://monero:18084
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--sub and --zmq-pub need to be on different ports. --zmq-pub needs to match the zmq-pub port of monerod and --sub can be any available port.

- --zmq-pub=tcp://monero:18084
- --log-level=4
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the default log-level should be 0, as 4 spams lots of data to disk.

- --webhook-ssl-verification=none
- --disable-admin-auth
- --admin-rest-server=http://0.0.0.0:8443/admin
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default should be https or port 8080. I would advocate for https, but transient certificates are a kludge.

- --rest-server=http://0.0.0.0:8443/basic
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

- --access-control-origin=lws:8443
- --confirm-external-bind
volumes:
- monerolws:/home/monero-lws
networks:
- monerolws

volumes:
monerolws: {}

networks:
monerolws:
driver: bridge