Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow: use turborepo to run script #257

Merged
merged 15 commits into from
Mar 5, 2024

Conversation

alexzhang1030
Copy link
Member

@alexzhang1030 alexzhang1030 commented Mar 2, 2024

This PR adds turborepo for task pipelineing and cache.

Additional messages:

  • ./packages/xxx... is two parts. ... means dependencies, and ./ means relative path.
  • we run build client twice when executing turbo build, because the electron and browser-extension packages implicitly depend on the client package, so we should build the client before executing build packages.

Copy link

netlify bot commented Mar 2, 2024

Deploy Preview for vue-devtools-docs canceled.

Name Link
🔨 Latest commit 5d1ae1c
🔍 Latest deploy log https://app.netlify.com/sites/vue-devtools-docs/deploys/65e5549e79f34300087b153b

@webfansplz
Copy link
Member

Great work. Can we use dependsOn option to improve it?

@alexzhang1030
Copy link
Member Author

alexzhang1030 commented Mar 2, 2024

Great work. Can we use dependsOn option to improve it?

Yes, we can. But unfortunately, dependsOn cannot declare the dependencies like sometPackage...

Like:

{
  "foo#build": {
    "dependsOn": ["bar#build"]
  }
}

If the bar depends on baz, turbo cannot calculate the dependency graph by these.

@alexzhang1030
Copy link
Member Author

I think something are messed, I will find it out later(maybe tomorrow :(

@alexzhang1030
Copy link
Member Author

Great work. Can we use dependsOn option to improve it?

After some investigation, ur right! We have to improve dependsOn on some packages.

CI passed, and this PR can merge at any time.

@webfansplz
Copy link
Member

webfansplz commented Mar 3, 2024

Awesome work, but we now seem to be having some issues with the cache not updating at build time.

Reproduction step:

  1. change the client file
  2. run build shell
  3. run playground (work fine)
  4. run the standalone app (work failed, the last cache was used)

@webfansplz webfansplz changed the title feat: add turborepo workflow: use turborepo to run script Mar 5, 2024
@webfansplz webfansplz merged commit 495cade into vuejs:main Mar 5, 2024
6 checks passed
@alexzhang1030 alexzhang1030 deleted the feat/turborepo branch March 5, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants