Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[accname PR 183] Step 2C includes controls with value that are directly referenced by labelledby or describedby #2210

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

pkra
Copy link
Member

@pkra pkra commented May 23, 2024

Moved from w3c/accname#183

@pkra
Copy link
Member Author

pkra commented May 23, 2024

This move was a bit messier since the PR is a year old and had merge conflicts.

I fixed two details which I hope are editorial:

  • I restored the deleted space after "combobox" (second changed line) seems erroneous.
  • I changed the closing ol tag to a closing ul tag to match the change in the opening tag.

@smhigley could you please double check when you find the time?

@pkra pkra force-pushed the monorepo_history--accname-PR183 branch from dc15b14 to 405fb4f Compare May 23, 2024 14:25
@pkra
Copy link
Member Author

pkra commented May 23, 2024

Ugh - I had forgotten to stage the fixed merge conflicts. I've force pushed the correct merge now.

@pkra pkra changed the base branch from monorepo_history--accname to main June 12, 2024 19:32
@pkra pkra changed the title [Monorepo] [accname PR 183] Step 2C includes controls with value that are directly referenced by labelledby or describedby [accname PR 183] Step 2C includes controls with value that are directly referenced by labelledby or describedby Jun 12, 2024
@pkra
Copy link
Member Author

pkra commented Jun 12, 2024

Now pointing to main.

Copy link
Contributor

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MelSumner MelSumner requested a review from accdc July 8, 2024 18:18
@smhigley
Copy link
Contributor

smhigley commented Jul 8, 2024

Thanks for porting this over, @pkra! The ol > ul change actually wasn't part of the original committed change, so I think I'll remove that part and just leave the change in wording. I think it got introduced in resolving merge conflicts somewhere 😅

Copy link

netlify bot commented Jul 8, 2024

Deploy Preview for wai-aria ready!

Name Link
🔨 Latest commit d8b5a69
🔍 Latest deploy log https://app.netlify.com/sites/wai-aria/deploys/668c7124d35639000809a529
😎 Deploy Preview https://deploy-preview-2210--wai-aria.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants