Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[html-aam PR 538] Specify AXAPI behaviour for low, high, and optimum meter attributes #2339

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[html-aam PR 538] Specify AXAPI behaviour for low, high, and optimum meter attributes #2339

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad6afcb
Migrate changes from html-aam pr #538
Sep 19, 2024
fe780cb
chore: prettier
rahimabdi Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions html-aam/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10958,7 +10958,10 @@ <h4 id="att-high">`high`</h4>
<tr>
<th><a href="https://developer.apple.com/reference/appkit/nsaccessibility">AX</a></th>
<td>
<div class="general">Not mapped</div>
<div class="general">
Expose "optimal value" via `AXValueDescription` if &lt;value&gt; is greater than or equal to &lt;high&gt;. Expose "suboptimal value" if &lt;value&gt; is less than &lt;high&gt; and
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rahimabdi 's migrated comment:

Relevant WebKit code: https://github.com/WebKit/WebKit/blob/c330ea99229f6bb478dde74497ee652e44a3d7d5/Source/WebCore/html/HTMLMeterElement.cpp#L172

This looks correct for high. We'll also need to add the case for when the value is less than "low" (for which this is exposed as "critical value").

greater than or equal to &lt;low&gt;.
</div>
</td>
</tr>
<tr>
Expand Down Expand Up @@ -11911,7 +11914,10 @@ <h4 id="att-low">`low`</h4>
<tr>
<th><a href="https://developer.apple.com/reference/appkit/nsaccessibility">AX</a></th>
<td>
<div class="general">Not mapped</div>
<div class="general">
Expose "suboptial value" via `AXValueDescription` if &lt;value&gt; is greater than or equal to &lt;low&gt; and less than &lt;high&gt;. If &lt;value&gt; is less than &lt;low&gt;,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rahimabdi's migrated comment:

Relevant WebKit code: https://github.com/WebKit/WebKit/blob/c330ea99229f6bb478dde74497ee652e44a3d7d5/Source/WebCore/html/HTMLMeterElement.cpp#L163

For low:

If value is less than or equal to low, then value is "optimal value"
if value is less than or equal to high (but greater than low), then value is "suboptimal value"
else, value is "critical value"
Also, looks like there is a typo for the word "suboptimal" here.

expose "critical value".
</div>
</td>
</tr>
<tr>
Expand Down Expand Up @@ -13090,7 +13096,7 @@ <h4 id="att-optimum">`optimum`</h4>
<tr>
<th><a href="https://developer.apple.com/reference/appkit/nsaccessibility">AX</a></th>
<td>
<div class="general">Not mapped</div>
<div class="general">Expose "optimal value" via `AXValueDescription` if &lt;value&gt; is greater than or equal to &lt;optimum&gt;.</div>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rahimabdi 's migrated comment:

Relevant WebKit code: https://github.com/WebKit/WebKit/blob/c330ea99229f6bb478dde74497ee652e44a3d7d5/Source/WebCore/html/HTMLMeterElement.cpp#L184

For optimum:

If value is greater than or equal to low AND value is less than or equal to high then value is "optimal value"
Else, value is "suboptimal value"
Note that in this case, there is no "critical value".

</td>
</tr>
<tr>
Expand Down