Flag custom-state-pseudo-class as discontinued #1164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The WICG spec moved to actual standardization with two parts: 1. The IDL part was moved to HTML in whatwg/html#8467 2. The CSS part is to be integrated in Selectors, see w3c/csswg-drafts#4805 This flags the spec as obsoleted by these two specs, using `selectors-4` for the CSS part. The CSS WG resolution mentions Selectors 5 but it does not exist yet.
specs.json
Outdated
| "standing": "discontinued", | ||
| "obsoletedBy": [ | ||
| "html", | ||
| "selectors-4" |
There was a problem hiding this comment.
Suggested change
| "selectors-4" | |
| "selectors-5" |
As annoying as it is, I think the right solution is not to merge this until the CSS bits actually surface in a new css-selectors-5; at least, here is my reasoning:
- neither the spec nor the repo are marked as discontinued
- clearly the HTML spec has taken over the IDL bit, but this is properly taken care of by your patch in https://github.com/w3c/webref/pull/1119/files
- you can't quite make sense of the feature without what's described in the spec until it gets moved into the new CSS selector 5 spec
- referencing css-selectors-4 when it doesn't actually describe the feature doesn't really help anyone
There was a problem hiding this comment.
Works for me. Let's park this for now!
|
https://wicg.github.io/custom-state-pseudo-class/ now redirects to the HTML spec, which breaks the webref patch. Given there is no sign of imminent progress on css-selectors-5, I guess we should make the spec obsoletedby html only at this point, and file an issue to add the new selectors spec when it arises. I'll update the PR in that direction. |
it should also be marked as obsolted by css-selectors-5 see #1337
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WICG spec moved to actual standardization with two parts:
This flags the spec as obsoleted by these two specs, using
selectors-4for the CSS part. The CSS WG resolution mentions Selectors 5 but it does not exist yet. Alternatively, we could keep this PR open until the CSS part gets specified, or not mentionselectors-4at all for now. Not sure which is better. Merging earlier rather than later would help with Webref (to remove the duplicate IDL).