Fix issue with handling of missing nights at the start of the recording in part 5 MM analysis #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- simplifies qwindow2timestamp to be just a numeric to timestamp conversion without epoch corrections. - catches when first midnight is not within 24 hours of the recording start, and then assigns qqq[1] to the first midnight minus 24 hours. - deals with 24:00:00 not existing outside the function in one place - rename function name fixTime to be more intuitive
… part of qwindow
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1039
This PR:
qwindow2timestampto be just about converting numeric to timestamps without the complexity of epoch corrections.@jhmigueles it may be best if you could review this PR, because this relates to code we both have worked on.
EDIT: I forgot to mention that my understanding is now that this problem was specific to multiple days of nonwear at the start of the recording. If we have a recording where days in the middle are invalid then there should not be a problem for this part of the code. But it may be good if you could also check that this observation is correct.
Checklist before merging:
inst/NEWS.Rdwith a user-readable summary. Please, include references to relevant issues or PR discussions.DESCRIPTIONfile, if you think you made a significant contribution.