Add imagePullSecrets to deployment template #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 29, 2024 15:31
Signed-off-by: Razvan Valceanu <razvan.valceanu@metaminds.com>
Signed-off-by: Razvan Valceanu <razvan.valceanu@metaminds.com>
waldner
approved these changes
Mar 29, 2024
|
Right, personally, I'd put the pull secret in the service account but since there's just a single deployment here it doesn't really matter. Since this repo (as many other cert-manager webooks) is based on the sample repository here https://github.com/cert-manager/webhook-example, you might want to submit a PR with this change there as well. |
|
Thanks! Will do. I thought about putting it in the SA, but since there is only one Deployment I just thought it was easier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, it's me again
I am pulling the chart and the image from an internal Harbor registry that replicates the one you have on ghcr. Unfortunately it requires authentication so I've added a pull request to add imagePullSecrets to the helm chart Deployment template.
Thank you for your time and patience! :)