Remove the global Buffer dependency
#319
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The global `Buffer` is used for loading base64 encoded string. However, this **implicit** and **global** dependency makes some confusions and problems (wasmerio#294, wasmerio#305, and ruby/ruby.wasm#182). The use of `Buffer` here is limited, so we can easily replace this by using `atob` function. This simplifies user's build settings and reduces the file size since there is no need to include Buffer.
|
Superseded by #345. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The global
Bufferis used for loading base64 encoded string. However, this implicit and global dependency make some confusion and problems (#294, #305, and ruby/ruby.wasm#182).The use of
Bufferhere is limited, so we can easily replace this by usingatobfunction. This simplifies the user's build settings and reduces the file size since there is no need to include Buffer.Thank you.