fix: made some changes to fix custom elements not being sized correctly #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Classnames and styles are now injected by default when using WebChatCustomElement.
ethanwinters
approved these changes
Jul 16, 2024
package.json
Outdated
| @@ -21,6 +21,9 @@ | |||
| "semantic-release": "semantic-release", | |||
| "test": "jest" | |||
| }, | |||
| "dependencies": { | |||
| "semver-compare": "^1.0.0" | |||
There was a problem hiding this comment.
Lets use the other semver package that is a module and wasn't taken down from the other PR.
Also probably a good time to bump up from node 14 here.
BREAKING CHANGE: Classnames and styles are now injected by default when using WebChatCustomElement.
TazmanianDI
force-pushed
the
custom-element-changes
branch
from
715e83e
to
84ba0aa
Compare
watson-github-bot
pushed a commit
that referenced
this pull request
Jul 17, 2024
# [2.0.0](v1.1.1...v2.0.0) (2024-07-17) ### Bug Fixes * made some changes and fixes ([#27](#27)) ([182d185](182d185)) * made some changes to fix custom elements not being sized correctly ([#28](#28)) ([13ef8f7](13ef8f7)) ### BREAKING CHANGES * Classnames and styles are now injected by default when using WebChatCustomElement. * Removed the deprecated withWebChat hook. * Renamed the "renderCustomResponse" prop to "renderUserDefinedResponse". * Removed the CustomResponsePortalsContainer component. - Added support for the "userDefinedResponse" event added in web chat 8.2.0. - Fixed an order bug that can occur if a user defined response is fired during the render process in some cases. This meant reworking the portals container interface which was a breaking change and we decided to just remove it from the public API. - Added support for usages on cp4d so the library will properly calculate the endpoints for the web chat entry script.
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Classnames and styles are now injected by default when using WebChatCustomElement.