Swift 3.0 #45
Open
Swift 3.0 #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated FBSnapshotTestCase to version 2.1.2 for swift3 Updated podfile syntax
* xcpretty uses sub gem wich needs at least 2.2.2 * pod file to enable swift3 needs at least cocoapods 1.0 Updated screenshots for tests again, because testing with xcjobs created pixel differences again. (Maybe that was the differences i found while testing with Xcode and tried to correct in commit #5026d7a)
…es again so the screenshots are updated also.
…g bundle identifier.
|
I am not able to get the signing running for the CI, but the tests are running on my machine locally. @watsonbox perhaps you could merge this and check the signing with your profile like it was before. thanks. |
|
Do we know if this development is going to be kept up to date? Or is there a way to import this into my project through CocoaPods |
|
Hey @Treverr , |
|
@watsonbox Is this still maintained? I'd love to help! |
|
example not woking properly |
|
@watsonbox @sishpal How about now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I updated the code to compile with xcode8 and swift3. I also needed to update the screenshorts for the visual tests, because the rendering on iOS 10 is some pixel different.
Cheers