Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ARM/ARM64/AMD64 architectures #311

Closed
wants to merge 1 commit into from
Closed

Support ARM/ARM64/AMD64 architectures #311

wants to merge 1 commit into from

Conversation

xunholy
Copy link

@xunholy xunholy commented Mar 20, 2020

Fixes:

  • Support ARM architecture #309
  • refactor Dockerfile names to maintain correct file type and IDE linting
  • remove unnecessary for loops building different ARCHS
  • remove hardcoded GOARCH and GOOS on go build
  • encapsulate build process inside docker therefore no longer having to configure build dependencies on the local machine, however, it still allows for local development if you do not wish to use docker.

TODO:

  • refactor image tags in GitHub actions workflow
  • cleanup makefile & remove unnecessary functions

Suggestions:

  • update go modules with go mod init and use Golang GO111MODULE=on to keep consistent with the latest best practices
  • update Dockerfiles to cache dependencies go mod download (dependant on the previous suggestion)

@xunholy xunholy changed the title adding support for multi-architecture docker images Support ARM/ARM64/AMD64 architectures Mar 20, 2020
@xunholy
Copy link
Author

xunholy commented Mar 20, 2020

@rndstr comments in response to the old thread.

this agent installs other agents which would need to be built for ARM64 as well (like https://github.com/weaveworks/scope)

I'm happy to work with your team to make all these images cross-compatible with different architectures. I'm currently involved in a large community that are running Kubernetes clusters using Raspberry Pi's, hence ARM architecture - You can also see that we've been building Flux for ARM architecture among many other opensource projects: https://github.com/raspbernetes/multi-arch-images

we probably don't want to move to GH actions in this repo

I don't mind, Github actions were free and easy for me to test, the current CircleCI config looked a bit daunting at first but if this is the mandate I'd be happy to give it a crack to update it there.

@xunholy
Copy link
Author

xunholy commented Mar 25, 2020

@rndstr was there any update?

@rndstr
Copy link

rndstr commented Apr 1, 2020

@xunholy not much changed unfortunately. There is interest in supporting ARM64 but I'm not sure how soon this will be picked up.

@xunholy
Copy link
Author

xunholy commented Sep 26, 2020

Closing PR due to community inactivity and I no longer use weave, happy to pick up and update everything when there is interest.

@xunholy xunholy closed this Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants