Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: framework agnostic component preview solution #563

Closed
wants to merge 2 commits into from

Conversation

sanyuan0704
Copy link
Contributor

Summary

Preview component demo for other framework instead of React-only.

Related Issue

#133

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

Copy link

netlify bot commented Jan 20, 2024

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit e157a30
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/65ab88fb4dbed70008369cf6
😎 Deploy Preview https://deploy-preview-563--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 65 (🔴 down 1 from production)
Accessibility: 79 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@sanyuan0704 sanyuan0704 marked this pull request as draft January 20, 2024 07:37
@sanyuan0704 sanyuan0704 force-pushed the feat/preview-framework-agnostic branch from 652762f to e157a30 Compare January 20, 2024 08:48
@10Derozan
Copy link
Member

Maybe we need a boolean configure to distinguish react and solidjs, because their entry is not the same.

@10Derozan
Copy link
Member

This has been replaced by #578

@10Derozan 10Derozan closed this Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants