Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme-default): Scroll to top button on docs | enableScrollToTop #622

Merged
merged 2 commits into from
Feb 13, 2024
Merged

feat(theme-default): Scroll to top button on docs | enableScrollToTop #622

merged 2 commits into from
Feb 13, 2024

Conversation

ArnavK-09
Copy link
Contributor

Summary

feat(theme-default): Scroll to top button on docs | enableScrollToTop
chore(docs): weixin -> wechat

reporefactr.2024-02-10.21-09-09.mp4

Related Issue

#133

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

Copy link

netlify bot commented Feb 10, 2024

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit b6beac7
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/65c987eb578bd4000973631d
😎 Deploy Preview https://deploy-preview-622--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 94 (🔴 down 1 from production)
Accessibility: 79 (🔴 down 18 from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@ArnavK-09
Copy link
Contributor Author

@sanyuan0704 hey can you please check what is wrong with workflow its stalled.

@SoonIter
Copy link
Member

LGTM, @sanyuan0704 cc, I think this feature can be exposed later to allow users to modify ScrollToTop component

@sanyuan0704
Copy link
Contributor

@ArnavK-09 Nice feature, thank you!

@sanyuan0704 sanyuan0704 merged commit d697778 into web-infra-dev:main Feb 13, 2024
8 checks passed
@sanyuan0704 sanyuan0704 mentioned this pull request Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants