Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[wpt] Ignore testdriver messages in
sandboxed_iframe.https.window.js
Fix two issues causing the test to fail spuriously upstream when run with WebDriver [0]: a. testdriver.js uses regular `postMessage()`/`onmessage` to communicate testdriver commands between the parent and child frames. Unfortunately, until [1] is resolved, tests that use `onmessage` need to be aware of this implementation detail and ignore the internal messages. b. The parent needs `testdriver(-vendor).js` too so that testdriver commands from the child frame are correctly pumped out [2] to the harness, which will send the WebDriver command. Content shell currently passes the test because its testdriver is backed by internal JS bindings that directly hook into the browser. [0]: https://wpt.fyi/results/serial/requestPort/sandboxed_iframe.https.window.html?run_id=5088854063448064 [1]: #48326 [2]: https://github.com/web-platform-tests/wpt/blob/8ae822f0/tools/wptrunner/wptrunner/testdriver-extra.js#L22 Bug: None Change-Id: Iddb130f92c1877e389a46cb89a35c21bbfd1b625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5888384 Reviewed-by: Jack Hsieh <chengweih@chromium.org> Commit-Queue: Jonathan Lee <jonathanjlee@google.com> Cr-Commit-Position: refs/heads/main@{#1359563}
- Loading branch information