add video_replay sample #1593
Open
add video_replay sample #1593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
fippo
commented
Feb 27, 2023
| const nextFrame = await ivf.readFrame(); | ||
| if (nextFrame) { | ||
| decoder.decode(new EncodedVideoChunk({ | ||
| timestamp: Number(nextFrame.timestamp - firstFrame.timestamp) * 1000, |
There was a problem hiding this comment.
I am not sure this is correct or it takes the headers timescale into account. But I don't have a great sample file to check at hand.
which allows replaying IVF files generated by video_replay in the browser. This is useful for debugging issues like https://bugs.chromium.org/p/chromium/issues/detail?id=1418596 where the native video_replay is using software decoder which do not show the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which allows replaying IVF files generated by video_replay in the browser. This is useful for debugging issues like
https://bugs.chromium.org/p/chromium/issues/detail?id=1418596
where the native video_replay is using software decoder which do not show the issue.