-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add video tutorial youtube link to README #307
Conversation
WalkthroughThe recent update introduces a comprehensive video tutorial to the README, aimed at guiding users through deploying the ding-dong-bot across WeChat, WhatsApp, and WeCom. This addition enriches the documentation by providing a visual and practical learning tool for users to follow along with ease. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (1)
docs/images/video-tutorial-img.png
is excluded by:!**/*.png
Files selected for processing (1)
- README.md (1 hunks)
Additional comments: 1
README.md (1)
- 30-37: The addition of the video tutorial section is a valuable enhancement to the README, providing users with a practical demonstration of deploying the ding-dong-bot across different platforms. However, there are a few recommendations to further improve this section:
- Accessibility: Consider adding an alternative text description for the image link to improve accessibility for users who rely on screen readers.
- Link Verification: Ensure the YouTube link is correct and accessible to all users. If the video is set to private or unlisted, it might not be viewable by everyone.
- Embedding Best Practices: While the current implementation directs users to YouTube, consider embedding the video directly into the README using an iframe if GitHub's markdown rendering supports it. This can provide a more seamless experience for users.
Overall, this is a great addition to the documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding your new video! It’s short, concise, and clear, very glad to add it!
Before we can merge it, can you replace the PNG with Webp format?
after that I think this PR will be good to be merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you very much for your contribution! You are welcome to join Wechaty Contributor Program1. Join Wechaty OrganizationI have invited you to join our Wechaty GitHub Organization; please accept it by following the above message. (See also: wechaty/PMC#16) 2. Update Your Wechaty Contributor Profile
3. Join the Wechaty Official Community on DiscordMake sure you have joined Discord! Join now if you are not: https://discord.gg/7q8NBZbQzt 4. Join The Contributor-Only WeChat RoomWe also have a WeChat room for contributors who can discuss Wechaty at a deeper level; you are welcome to join if interested. Please add @lijiarui wechat: ruirui_0914 and send her this PR link. She will invite you into the Wechaty Contributor Room. Cheers! |
I'm submitting a...
Checklist
Description
I've recorded a short tutorial of deploying ding-dong-bot with WeChat, WhatsApp, and WeCom. The Youtube video is added to the README along with a short description and preview image.
Does this PR introduce a breaking change?
Summary by CodeRabbit