Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ~10x performance regression by reverting a change #337

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

LGriffioen
Copy link
Contributor

change was introduced with zip64 support

Fixes #311

Changes proposed in this PR

Tests performed

  • performance of loading 10,000 files that are zipped is ~10x faster than development, and roughly where it was before the Zip64 changes
  • I'm not familiar enough with Zip64 to be able to test what impacts this change has on that functionality

Further info for the reviewer

  • Performance with large numbers of files is critical for us. This 10x improvement is taking a 20s operation down to under 2s

Open Issues

change was introduced with zip64 support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance regression when opening lots of zip archives
1 participant