-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Project #34
Update Project #34
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you try running the examples on SDK 33? I am working on fully compatibility with that because some calls have been deprecated....
- Moved permissions out of libs manifest file - documented the info in readme
e62d0c6
to
2ddc1a5
Compare
@martijnvanwelie I have only recently got the opportunity to look into this. I believe you are referring to these warnings when one builds the library:
My solution was to address these by putting in checks for API >=33 and then write the code path for both variations. I'll see what I can do. I'll submit it as part of this PR itself. |
@weliem I was still working on adding some code to this PR, but I see you are already working on it. Thanks for merging the PR anyways, it had some simple upgrades to the project. |
I did a couple of more fixes that had to be done and released a new version. Thx for your work! |
Updated some deps and added some helpful comments with links