feat: remove simulation #4417
Merged
feat: remove simulation #4417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5188b58 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tmm
reviewed
Nov 20, 2024
| @@ -86,7 +86,7 @@ export type CreateWriteContractReturnType< | |||
| | undefined | |||
| } | |||
| : Compute<ChainIdParameter<config, chainId>>) & | |||
| ConnectorParameter & { __mode?: 'prepared' } | |||
There was a problem hiding this comment.
Might be good to leave __mode here and just add a @deprecated comment so people that upgrade don't experience unexpected type errors if they were passing this in directly (to skip simulation).
tmm
reviewed
Nov 20, 2024
There was a problem hiding this comment.
Probably good to keep and deprecate __mode here too.
tmm
reviewed
Nov 20, 2024
|
Size Change: 0 B Total Size: 797 kB ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4417 +/- ##
==========================================
- Coverage 93.91% 85.72% -8.19%
==========================================
Files 278 271 -7
Lines 7178 6956 -222
Branches 831 699 -132
==========================================
- Hits 6741 5963 -778
- Misses 424 976 +552
- Partials 13 17 +4 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Mahmoudhpp
approved these changes
Nov 21, 2024
Magkoooh
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modern wallets (and wallets in general) should be smart enough to perform simulation & estimate gas on their side. This PR removes the need to perform simulations & gas estimations from the send trasnaction & contract write actions.