-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update metamask sdk and improve chain switching with metamask mobile #4422
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Size Change: +24.2 kB (+3.04%) Total Size: 821 kB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4422 +/- ##
=======================================
Coverage 94.03% 94.04%
=======================================
Files 278 279 +1
Lines 7147 7149 +2
Branches 827 827
=======================================
+ Hits 6721 6723 +2
Misses 412 412
Partials 14 14 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
This PR aims to solve an issue where the original logic of switchChain -> add if it's not present would cause an extra back and forth between dapp and the MetaMask wallet, particularly on Mobile to Mobile interactions.