Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for the leg_detector opencv3 bug #48

Closed
wants to merge 5 commits into from

Conversation

kdhansen
Copy link
Contributor

@kdhansen kdhansen commented Sep 12, 2016

This is a fix for #44 and in turn #47. I have changed the CvMat C-style calls to the corresponding C++style of opencv3. Also the fuzzy probability call predict_prob no longer exists, so I implemented a replacement. I have not done a comparison test with Indigo, as I have no working Indigo-installation, but it looks good to me on 16.04+Kinetic.

Karl D. Hansen added 3 commits September 12, 2016 11:53
The cv::ml package has been rewritten. I just changed the code to
accomodate the new api, maybe this does not conform to the way the new
cv::ml should be used...
In opencv3 the predict_prob method was removed from cv::ml::RTrees.
@kdhansen
Copy link
Contributor Author

It seems I cannot make Travis build. Can someone with superior knowledge take over, please?

Karl D. Hansen added 2 commits September 28, 2016 13:58
The dependency on the people_msgs package should be enough. This removes
warnings for the leg_detector and people_tracking_filter when building
with catkin_make_isolated and catkin build.
@kdhansen
Copy link
Contributor Author

Oh! I get it... Travis does not run Xenial (16.04) and Kinetic does not support Trusty (14.04). So we cannot test Kinetic code on Travis...

@130s
Copy link
Contributor

130s commented Feb 18, 2017

Sorry for the delay. #49 is finally ready for the review. Once it's merged you may rebase your PR to run test against.

@kdhansen kdhansen closed this Mar 27, 2017
@kdhansen kdhansen deleted the kinetic branch March 27, 2017 20:28
@kdhansen
Copy link
Contributor Author

@130s I tried rebasing on your k/update_travis branch, but for some reason I get the error with the haarcascade file in Travis:
"Cascade file /opt/ros/kinetic/share/OpenCV-3.1.0-dev/haarcascades/haarcascade_frontalface_alt.xml doesn't exist."

On another note, I totally screwed something up when rebasing, that is why I closed the pull request. I will open it when #49 has been merged.

@kdhansen
Copy link
Contributor Author

Ok, so OpenCV was just updated to 3.2.0. I tried changing the hardcoded location, now I get a pass on Travis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants