Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add navigation request pc #6659

Merged
merged 1 commit into from
May 11, 2021
Merged

Conversation

antosart
Copy link
Member

@antosart antosart commented May 6, 2021

This change stores a snapshot of the initiator policy container on the navigation request. This has no effect by itself, but together with a companion change to CSP it will enable to check policies consistently during the navigation, fixing whatwg/fetch#832 for navigation requests.


/browsing-the-web.html ( diff )
/infrastructure.html ( diff )

@antosart antosart force-pushed the add-navigation-request-pc branch from 8489007 to 1560796 Compare May 6, 2021 08:42
@antosart
Copy link
Member Author

antosart commented May 6, 2021

This change depends on whatwg/fetch#1231

source Outdated Show resolved Hide resolved
source Outdated Show resolved Hide resolved
@antosart antosart force-pushed the add-navigation-request-pc branch from 1560796 to 8518a0d Compare May 11, 2021 09:33
@antosart antosart force-pushed the add-navigation-request-pc branch from 8518a0d to 4572df3 Compare May 11, 2021 09:36
@annevk
Copy link
Member

annevk commented May 11, 2021

I would like @domenic to land this because of the source browsing context investigation he has been doing.

@annevk annevk requested a review from domenic May 11, 2021 09:52
@domenic
Copy link
Member

domenic commented May 11, 2021

This is good. @antosart consciously decided on source browsing context and even added tests, after I asked him in #6504.

@domenic domenic merged commit 8a27d72 into whatwg:main May 11, 2021
antosart added a commit to w3c/webappsec-csp that referenced this pull request May 12, 2021
This change depends on whatwg/fetch#1231 and whatwg/html#6659 which add and populate a request's policy container. This change relies on the request's policy container CSP list (instead of the request's client's environment setting object's CSP list) for the checks. This enforces consistency, since the the request's client's environment setting object's CSP list can change during the lifetime of an asynchronous fetch (for example, when following redirects, or when doing a response check), while the request's policy container CSP list is a snapshot at request's creation time.
ryandel8834 added a commit to ryandel8834/WebAppSec-CSP that referenced this pull request Aug 13, 2022
This change depends on whatwg/fetch#1231 and whatwg/html#6659 which add and populate a request's policy container. This change relies on the request's policy container CSP list (instead of the request's client's environment setting object's CSP list) for the checks. This enforces consistency, since the the request's client's environment setting object's CSP list can change during the lifetime of an asynchronous fetch (for example, when following redirects, or when doing a response check), while the request's policy container CSP list is a snapshot at request's creation time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants