Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add planner tests #261

Merged
merged 9 commits into from
Jul 10, 2023
Merged

Add planner tests #261

merged 9 commits into from
Jul 10, 2023

Conversation

marcofavorito
Copy link
Member

Proposed changes

Add tests that also run a planner over the compiled PDDL domain/problem, and check the solution found.

Fixes

Fix #246

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the develop branch (left side). Also, you should start your branch off our develop.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

Further comments

n/a

@codecov
Copy link

codecov bot commented Jul 9, 2023

Codecov Report

Merging #261 (d539ad9) into main (b4da5f3) will increase coverage by 0.18%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #261      +/-   ##
==========================================
+ Coverage   89.61%   89.79%   +0.18%     
==========================================
  Files          12       12              
  Lines         549      549              
==========================================
+ Hits          492      493       +1     
+ Misses         57       56       -1     
Flag Coverage Δ
unittests 89.79% <ø> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@francescofuggitti
Copy link
Member

Looks awesome, thanks!

@marcofavorito marcofavorito merged commit dd7b158 into main Jul 10, 2023
11 checks passed
@marcofavorito marcofavorito deleted the add-planner-tests branch July 10, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing parts for ICAPS23
2 participants