Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add true bool count to ColumnCountsMetric #1564

Merged
merged 3 commits into from
Sep 20, 2024
Merged

Add true bool count to ColumnCountsMetric #1564

merged 3 commits into from
Sep 20, 2024

Conversation

richard-rogers
Copy link
Contributor

Description

Include count of True bool values in ColumnCountsMetric

jamie256
jamie256 requested changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@jamie256 jamie256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes for initial count tracking look good, but lets remove the commented out code, ideally replace it with a test using an artifact that contains the older code's serialized data.

python/tests/core/metrics/test_column_metrics.py Outdated Show resolved Hide resolved
jamie256
jamie256 approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@jamie256 jamie256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@richard-rogers richard-rogers merged commit 933f988 into mainline Sep 20, 2024
14 checks passed
@richard-rogers richard-rogers deleted the dev/richard/bool-count branch September 20, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamie256 jamie256 jamie256 approved these changes

@FelipeAdachi FelipeAdachi Awaiting requested review from FelipeAdachi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richard-rogers @jamie256