Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle explicit segmentation keys #1566

Merged
merged 12 commits into from
Sep 25, 2024
Merged

Handle explicit segmentation keys #1566

merged 12 commits into from
Sep 25, 2024

Conversation

richard-rogers
Copy link
Contributor

Description

Allow segment_key_values in addition to segmented DatasetSchema

jamie256
jamie256 previously approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@jamie256 jamie256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Maybe cleanup some of the comments but the changes look right.

jamie256
jamie256 approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@jamie256 jamie256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@richard-rogers richard-rogers merged commit 4ad4cc9 into mainline Sep 25, 2024
14 checks passed
@richard-rogers richard-rogers deleted the dev/richard/manual-segment branch September 25, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamie256 jamie256 jamie256 approved these changes

@bernease bernease Awaiting requested review from bernease

@FelipeAdachi FelipeAdachi Awaiting requested review from FelipeAdachi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richard-rogers @jamie256