Fix enterProgram shortcut on control nodes #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ixes wierkstudio#40) Base64 embeds bytes into 6 bit units. It takes two units to properly encode a single byte. If you then decode this, you can conclude that the 4 additional bits contain no information. (Unless the input violates our assumption that it is a base64 encoding.) You can conclude that if $y = \lceil xs_{input} / s_{output}\rceil$ with x an integer, then $x <= \lfloor ys_{output} / s_{input}\rfloor$. This commit checks every added unit if it is the last, and doesn't add the null byte if it is. It might be more efficient to just use the larger array and slice off the null byte when it exists. It can be impossible to determine a true zero byte from padding if `inputSize < outputSize`, but for binary-to-text that requires an alphabet of more than 256 characters. Signed-off-by: anderium <33520919+anderium@users.noreply.github.com>
The node type for the enterProgram shortcut (enter/cmd+down) was not checked, because `programId` was assumed to be undefined for non-program nodes. It is actually also used by control nodes. This commit adds a double check that you actually use the shortcut on a program node.
anderium
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I
accidentallybased this on #41, if that is not accepted this should be cherry picked to only commit947f0a9.Only changes
packages/app-web/src/slices/blueprint/index.tsThe node type for the enterProgram shortcut (enter/cmd+down) was not checked, because
programIdwas assumed to be undefined for non-program nodes. It is actually also used by control nodes. This commit adds a double check that you actually use the shortcut on a program node.In this example I show that entering a program with keyboard shortcut
meta+downis possible, but this also tries to enter the non-existent program defined by the control nodeprogramId. You can see the program crashes because everything disappears, “everything” being the node and the “explore” message.example.mov