Improve relative time formatting in the notification activity. #3895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isira-Seneviratne
requested review from
cooltey,
dbrant and
sharvaniharan
as code owners
dbrant
requested changes
Apr 18, 2023
There was a problem hiding this comment.
This is an improvement, but might actually be too much of an improvement.
I'm not sure the "years ago" and "months ago" cases are really needed.
- If a notification was received "1 year ago", does it mean "1 year + 1 day", or does it mean "1 year + 364 days" ago? These are huge differences, and therefore no longer very useful.
- The "months" case will never be totally accurate because not all months have the same number of days.
Let's keep the maximum granularity as weeks, and if the time is greater than 10 weeks in the past, keep displaying it as the regular formatted date (as before).
Also, even in the weeks case, the DateUtils.getRelativeTimeSpanString() function can format it for us automatically, using the WEEK_IN_MILLIS constant, so we shouldn't need any new plurals resources.
Isira-Seneviratne
force-pushed
the
Notification_time_ago
branch
from
2b57d8a
to
298c039
Compare
Isira-Seneviratne
force-pushed
the
Notification_time_ago
branch
from
c795ea7
to
0ed177d
Compare
# Conflicts: # app/src/main/java/org/wikipedia/settings/Prefs.kt
# Conflicts: # app/src/main/java/org/wikipedia/settings/Prefs.kt # app/src/test/java/org/wikipedia/test/MockRetrofitTest.kt
# Conflicts: # gradle/libs.versions.toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the relative time formatting used in the notification activity for when the time difference is 1 week or greater.
Screenshots
Before
After
