Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ELY-2815] Renamed CA_JKS_LOCATION to CA_PKCS_LOCATION in TLS13AuthenticationTest #2218

Closed
wants to merge 1 commit into from
Closed

[ELY-2815] Renamed CA_JKS_LOCATION to CA_PKCS_LOCATION in TLS13AuthenticationTest #2218

wants to merge 1 commit into from

Conversation

luisa-ball
Copy link
Contributor

fjuma
fjuma approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@fjuma fjuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks very much @luisa-ball!

@fjuma fjuma added the +1 FJ label Oct 4, 2024
SoniaZaldana
SoniaZaldana approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@SoniaZaldana SoniaZaldana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@rsearls
Copy link
Contributor

rsearls commented Oct 4, 2024

1+ reviewed. Looks good

@luisa-ball luisa-ball closed this Oct 4, 2024
@luisa-ball luisa-ball deleted the ELY-2815 branch October 4, 2024 20:28
@SoniaZaldana
Copy link
Contributor

Hi @luisa-ball, we haven't yet merged this PR. Could you reopen it?

@luisa-ball
Copy link
Contributor Author

Hi, sorry! I was having issues with my GitHub I will send the PR again.

@luisa-ball luisa-ball restored the ELY-2815 branch October 4, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoniaZaldana SoniaZaldana SoniaZaldana approved these changes

@fjuma fjuma fjuma approved these changes

@luck3y luck3y luck3y approved these changes

@Skyllarr Skyllarr Awaiting requested review from Skyllarr Skyllarr is a code owner

Assignees
No one assigned
Labels
+1 FJ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@luisa-ball @rsearls @SoniaZaldana @luck3y @fjuma