Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WFLY-18502]: remote-helloworld-mdb Quickstart Common Enhancements CY2023Q3 #725

Closed
wants to merge 1 commit into from
Closed

[WFLY-18502]: remote-helloworld-mdb Quickstart Common Enhancements CY2023Q3 #725

wants to merge 1 commit into from

Conversation

ehsavoie
Copy link
Contributor

@ehsavoie ehsavoie commented Oct 5, 2023

No description provided.

emmartins
emmartins requested changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@emmartins emmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI I have not yet tried the enhanced quickstart, will do next monday, but some minor changes needed from looking at PR

remote-helloworld-mdb/pom.xml Outdated Show resolved Hide resolved
.github/workflows/quickstart_ci.yml Outdated Show resolved Hide resolved
.github/workflows/quickstart_ci.yml Outdated Show resolved Hide resolved
@ehsavoie ehsavoie force-pushed the WFLY-18502 branch 2 times, most recently from c27e541 to d33aa48 Compare October 9, 2023 09:58
emmartins
emmartins requested changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@emmartins emmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried locally the test without any issue, but there are a couple of changes you should revert, and please squash into a single commit

@ehsavoie ehsavoie force-pushed the WFLY-18502 branch 5 times, most recently from 73faf5b to 69a0652 Compare October 13, 2023 06:46
@ehsavoie
[WFLY-18502]: remote-helloworld-mdb Quickstart Common Enhancements CY…
b86215c 
…2023Q3

Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
@emmartins emmartins mentioned this pull request Oct 19, 2023
Merged
@emmartins
Copy link
Contributor

Replaced by #757

@emmartins emmartins closed this Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmartins emmartins emmartins requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ehsavoie @emmartins