Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WFLY-18467] ejb-security-programmatic-auth Quickstart Common Enhance… #760

Merged
merged 1 commit into from
Dec 13, 2023
Merged

[WFLY-18467] ejb-security-programmatic-auth Quickstart Common Enhance… #760

merged 1 commit into from
Dec 13, 2023

Conversation

PrarthonaPaul
Copy link

@PrarthonaPaul PrarthonaPaul commented Oct 20, 2023 •
edited
Loading

@openshift-ci
Copy link

openshift-ci bot commented Oct 20, 2023

Hi @PrarthonaPaul. Thanks for your PR.

I'm waiting for a wildfly member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

emmartins
emmartins reviewed Nov 2, 2023
View reviewed changes
.github/workflows/quickstart_ejb_security_programmatic_auth_ci.yml Outdated
pull_request:
types: [opened, synchronize, reopened, ready_for_review]
paths:
- ejb-security-programmatic-auth/**'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 'ejb-security-programmatic-auth/**'

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

emmartins
emmartins reviewed Nov 2, 2023
View reviewed changes
.github/workflows/quickstart_ejb_security_programmatic_auth_ci.yml Outdated
with:
QUICKSTART_PATH: ejb-security-programmatic-auth
TEST_PROVISIONED_SERVER: true
TEST_BOOTABLE_JAR: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove please

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed!

emmartins
emmartins reviewed Nov 2, 2023
View reviewed changes
ejb-security-programmatic-auth/pom.xml Outdated
@@ -182,7 +199,67 @@
</execution>
</executions>
</plugin>
<plugin>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be plugin management

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

emmartins
emmartins reviewed Nov 2, 2023
View reviewed changes
ejb-security-programmatic-auth/pom.xml Outdated
<artifactId>wildfly-maven-plugin</artifactId>
<configuration>
<feature-packs>
<feature-pack> <location>org.wildfly:wildfly-galleon-pack:${version.server}</location>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please break line

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed!

emmartins
emmartins reviewed Nov 2, 2023
View reviewed changes
...c-auth/src/main/java/org/jboss/as/quickstarts/ejb_security_programmatic_auth/EJBServlet.java
@@ -0,0 +1,56 @@
/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please align javadoc and html content with the one you added at https://github.com/PrarthonaPaul/quickstart/blob/main/ejb-security-context-propagation/src/main/java/org/jboss/as/quickstarts/ejb_security_context_propagation/EJBServlet.java

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed!

emmartins
emmartins reviewed Nov 2, 2023
View reviewed changes
ejb-security-programmatic-auth/src/main/java/webapp/WEB-INF/beans.xml Outdated
@@ -0,0 +1,22 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure we need this, you are not adding any CDI injection

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed it

emmartins
emmartins reviewed Nov 2, 2023
View reviewed changes
...th/src/test/java/org/jboss/as/quickstarts/ejb_security_programmatic_auth/BasicRuntimeIT.java
private static final String DEFAULT_SERVER_HOST = "http://localhost:8080/ejb-security-programmatic-auth";

@Test
public void testHTTPEndpointIsAvailable() throws IOException, InterruptedException, URISyntaxException {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps you need to add the user auth?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added it

emmartins
emmartins reviewed Nov 2, 2023
View reviewed changes
ejb-security-programmatic-auth/pom.xml
<layers>
<!-- layers may be used to customize the server to provision -->
<layer>cloud-server</layer>
</layers>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think you need to provision the cli script to change the config

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it, but when I run mvn clean package -Pprovisioned-server, I get this error:

org.jboss.as.cli.CommandFormatException: Failed to get the list of the operation properties: "WFLYCTL0030: No resource definition is registered for address [
    ("subsystem" => "ejb3"),
    ("application-security-domain" => "quickstart-domain")
]": Failed to get the list of the operation properties: "WFLYCTL0030: No resource definition is registered for address [
    ("subsystem" => "ejb3"),
    ("application-security-domain" => "quickstart-domain")
]"

I did not have trouble when I added the configurations for deploying the application.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you probably need to add the ejb layer besides the cloud-server

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added it.
Thanks!

@PrarthonaPaul PrarthonaPaul force-pushed the WFLY-18467 branch 3 times, most recently from 40e9312 to 7ba41fc Compare November 6, 2023 14:52
@PrarthonaPaul PrarthonaPaul marked this pull request as ready for review November 6, 2023 15:06
@PrarthonaPaul
Copy link
Author

Hello @emmartins
I have gone through this quickstart and it works both for the standard configuration and for the integration-testing profile.

emmartins
emmartins approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@emmartins emmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All working, there is further improvements I would like, such as replacing the exec:exec with a unit test, but let's do that on another PR

@emmartins emmartins merged commit 4ca06cc into wildfly:main Dec 13, 2023
19 checks passed
@emmartins
Copy link
Contributor

merged, thank you @PrarthonaPaul

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmartins emmartins emmartins approved these changes

Assignees
No one assigned
Labels
needs-ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PrarthonaPaul @emmartins