Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-19622] Removes unused Arquillian dependencies and doc resources #945

Merged
merged 1 commit into from
Aug 8, 2024
Merged

[WFLY-19622] Removes unused Arquillian dependencies and doc resources #945

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CONTRIBUTING.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,9 +265,9 @@ See the https://github.com/wildfly/quickstart/blob/11.x/pom.xml#L155[WildFly par

** CDI should be used as the programming model
** Avoid using a `web.xml` file if possible. Use a `faces-config.xml` to activate JSF if needed.
** Any tests should use Arquillian.
** Any tests should use JUnit.

* If the quickstart persists to a database, you must use a unique datasource JNDI name and connection URL for the application and for any Arquillian tests that it provides. Do not use the JNDI name `java:jboss/datasources/ExampleDS`. Failure to use unique names can result in a `DuplicateServiceException` when more than one quickstart is deployed to the same server.
* If the quickstart persists to a database, you must use a unique datasource JNDI name and connection URL for the application and for any tests that it provides. Do not use the JNDI name `java:jboss/datasources/ExampleDS`. Failure to use unique names can result in a `DuplicateServiceException` when more than one quickstart is deployed to the same server.

* Be sure to test the quickstart in {JBDSProductName}, which strictly enforces Jakarta EE coding rules!

Expand Down
396 changes: 2 additions & 394 deletions guide/KitchensinkQuickstart.asciidoc
View file
Open in desktop

Large diffs are not rendered by default.

Binary file removed guide/gfx/eclipse_arquillian_0.png
View file
Open in desktop
Binary file not shown.
Binary file removed guide/gfx/eclipse_arquillian_1.png
View file
Open in desktop
Binary file not shown.
Binary file removed guide/gfx/eclipse_arquillian_11.png
View file
Open in desktop
Binary file not shown.
Binary file removed guide/gfx/eclipse_arquillian_12.png
View file
Open in desktop
Binary file not shown.
Binary file removed guide/gfx/eclipse_arquillian_2.png
View file
Open in desktop
Binary file not shown.
Binary file removed guide/gfx/eclipse_arquillian_3.png
View file
Open in desktop
Binary file not shown.
Binary file removed guide/gfx/eclipse_arquillian_4.png
View file
Open in desktop
Binary file not shown.
15 changes: 0 additions & 15 deletions kitchensink/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,21 +185,6 @@
<scope>provided</scope>
</dependency>

<!-- Optional, but highly recommended -->
<!-- Arquillian allows you to test enterprise code such as EJBs and Transactional(JTA)
JPA from JUnit/TestNG -->
<dependency>
<groupId>org.jboss.arquillian.junit</groupId>
<artifactId>arquillian-junit-container</artifactId>
<scope>test</scope>
</dependency>

<dependency>
<groupId>org.jboss.arquillian.protocol</groupId>
<artifactId>arquillian-protocol-servlet-jakarta</artifactId>
<scope>test</scope>
</dependency>

<!-- JBoss Logging is provided by the server -->
<dependency>
<groupId>org.jboss.logging</groupId>
Expand Down
17 changes: 0 additions & 17 deletions microprofile-config/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,23 +130,6 @@
<scope>test</scope>
<type>jar</type>
</dependency>
<dependency>
<groupId>org.jboss.arquillian.container</groupId>
<artifactId>arquillian-container-test-spi</artifactId>
<scope>test</scope>
<type>jar</type>
</dependency>
<dependency>
<groupId>org.jboss.arquillian.junit</groupId>
<artifactId>arquillian-junit-container</artifactId>
<scope>test</scope>
</dependency>
<!-- this should be replaced with -remote once the MicroProfileConfigIT is converted to for remote using -->
<dependency>
<groupId>org.wildfly.arquillian</groupId>
<artifactId>wildfly-arquillian-container-managed</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.jboss.resteasy</groupId>
<artifactId>resteasy-client</artifactId>
Expand Down
215 changes: 0 additions & 215 deletions ...onfig/src/test/java/org/wildfly/quickstarts/microprofile/config/MicroProfileConfigIT.java
View file
Open in desktop

This file was deleted.

12 changes: 0 additions & 12 deletions microprofile-fault-tolerance/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,18 +165,6 @@
<artifactId>junit</artifactId>
<scope>test</scope>
</dependency>
<!-- Arquillian allows you to test enterprise code such as EJBs and
Transactional(JTA) JPA from JUnit/TestNG -->
<dependency>
<groupId>org.jboss.arquillian.junit</groupId>
<artifactId>arquillian-junit-container</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.wildfly.arquillian</groupId>
<artifactId>wildfly-arquillian-common</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.jboss.resteasy</groupId>
<artifactId>resteasy-client</artifactId>
Expand Down
6 changes: 3 additions & 3 deletions microprofile-health/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,9 +139,9 @@
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.wildfly.arquillian</groupId>
<artifactId>wildfly-arquillian-common</artifactId>
<scope>test</scope>
<groupId>org.wildfly.core</groupId>
<artifactId>wildfly-cli</artifactId>
<classifier>client</classifier>
</dependency>
</dependencies>

Expand Down
3 changes: 1 addition & 2 deletions ...ealth/src/test/java/org/wildfly/quickstarts/microprofile/health/MicroProfileHealthIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@
import java.util.Optional;

/**
* Simple tests for MicroProfile Health quickstart. Arquillian deploys an JAR archive to the application server, which
* contains several health checks and verifies that they are correctly invoked.
* Simple tests for MicroProfile Health quickstart.
*
* @author <a href="mstefank@redhat.com">Martin Stefanko</a>
*
Expand Down
5 changes: 0 additions & 5 deletions microprofile-reactive-messaging-kafka/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,11 +201,6 @@
</dependency>

<!-- Other test dependencies -->
<dependency>
<groupId>org.wildfly.arquillian</groupId>
<artifactId>wildfly-arquillian-common</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.eclipse.microprofile.rest.client</groupId>
<artifactId>microprofile-rest-client-api</artifactId>
Expand Down
36 changes: 0 additions & 36 deletions remote-helloworld-mdb/src/test/resources/arquillian.xml
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion shared-doc/attributes.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,6 @@ endif::[]
:useEclipseDeployEARDocUrl: {guidesBaseUrl}USE_JBDS.adoc#deploy_and_undeploy_a_quickstart_ear_project
:useProductHomeDocUrl: {guidesBaseUrl}USE_OF_{jbossHomeName}.adoc#use_of_product_home_and_jboss_home_variables
:configureMavenDocUrl: {guidesBaseUrl}CONFIGURE_MAVEN_JBOSS_EAP.adoc#configure_maven_to_build_and_deploy_the_quickstarts
:arquillianTestsDocUrl: {guidesBaseUrl}RUN_ARQUILLIAN_TESTS.adoc#run_the_arquillian_tests
:addUserDocUrl: {guidesBaseUrl}CREATE_USERS.adoc#create_users_required_by_the_quickstarts
:addApplicationUserDocUrl: {guidesBaseUrl}CREATE_USERS.adoc#add_an_application_user
:addManagementUserDocUrl: {guidesBaseUrl}CREATE_USERS.adoc#add_an_management_user
Expand Down
Loading
Loading