Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidation with SmallRye Common #100

Merged
merged 6 commits into from
Jan 19, 2024
Merged

Consolidation with SmallRye Common #100

merged 6 commits into from
Jan 19, 2024

Conversation

dmlloyd
Copy link
Member

@dmlloyd dmlloyd commented Jan 12, 2024

Take several steps towards completing #87.

This PR should be merged after #94.

@jamezp
Copy link
Member

jamezp commented Jan 19, 2024

I think this makes sense, but IMO it should be a major version bump. Speaking of, the version seems to be 1.8.0.Final no SNAPSHOT :)

It will make the migration a bit easier for WildFly as the first step will be to add the SmallRye Common modules first.

@dmlloyd
Copy link
Member Author

dmlloyd commented Jan 19, 2024

Do you mean a major version bump before the deprecations, after the removals, or both? I'm Ok moving to 2.0.0-SNAPSHOT now in any case.

Copy link
Member

@jamezp jamezp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmlloyd dmlloyd merged commit f67ce2b into wildfly:main Jan 19, 2024
1 check passed
@dmlloyd dmlloyd deleted the smallrye branch January 19, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants