Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-14255] Make reuseXForwarded and rewriteHost configurable #444

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

baranowb
Copy link
Contributor

@baranowb baranowb commented Nov 3, 2021

Copy link

@PrarthonaPaul PrarthonaPaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @baranowb
The proposal looks good! I have added some minor comments, please feel free to let me know if you have any questions.

Should be part of model reference. Possibly could be documented in Undertow as well?

== Release Note Content
See Overview

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @baranowb
Thanks for making the changes. Just a minor comment, the contents of this section is used to compile the release notes for WildFly. If that is done automatically through some scripts, then the release note for this feature might show "See Overview", so it would be good to update that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not done via scripts and wouldn't be blindly copied into the announcement; it's just a convenience for me when I manually write the release announcement if the feature team has drafted suitable language instead of requiring me to start from scratch on a very busy day.

I don't want feature teams automatically blocking approving analyses based on this section, but it's helpful to me if the team comes up with suitable language that follows the basic pattern of how I introduce features in the release announcement blogs. At a high level vaguely understandable to user interested in what's new in WF, state what area was improved to allow you to do what that you couldn't before.

Note I'm not looking for adoc stuff here like the hyperlinks I always use, nor am I asking for boilerplate stuff like 'This feature is provided at the preview stability level.'

@bstansberry bstansberry merged commit 6648ec3 into wildfly:main Jul 3, 2024
1 check passed
@bstansberry
Copy link
Contributor

Thanks @baranowb @fl4via and @PrarthonaPaul

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants